-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the same argument filters as #222 for .import.rio_rdata, .import.rio_xls, and .import.rio_ods #223
Closed
1 of 3 tasks
Labels
Milestone
Comments
3 tasks
Happy to have you tackle this! Your call on whether to submit separately or as one PR. |
bokov
added a commit
to bokov/rio
that referenced
this issue
Sep 23, 2019
gesistsa#223. Also more detailed tests.
6 tasks
bokov
added a commit
to bokov/rio
that referenced
this issue
Sep 23, 2019
…to 'load()' nor to 'readRDS()' because those underlying functions cannot accept '...' arguments. Instead, the length of '...' is checked and if > 0 a warning is issued. With corresponding tests. As proposed in gesistsa#223
This was referenced Sep 23, 2019
Went with separate, so it would be easier to review |
leeper
pushed a commit
that referenced
this issue
Oct 3, 2019
* Added dynamic argument checking for 'readODS:read_ods()' as proposed in #223. Also more detailed tests.
3 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please specify whether your issue is about:
in #222, the
intersect()
andsetdiff()
functions were used to generically filter the arguments passed via...
so that only the ones recognized by the underlying import function would get passed to it.The functions
load()
,readxl::read_xls()
, andreadODS::read_ods()
underlying.import.rio_rdata()
,.import.rio_xls()
, and.import.rio_ods()
respectively have the same problem.May I submit a PR/s implementing the same argument-filtering for those functions? If yes, do you prefer a separate PR for each, or grouped together?
The text was updated successfully, but these errors were encountered: