Ignoring files should not cause error

[fahad19]

Problem

I am trying to run alex on a directory of markdown files, and one of the files there is ignored. And alex throws an error.

Expectation

I think it should just silently ignore the file, without exiting with an error failing the build.

Reproduce

To reproduce:

• Have two files in root: README.md and MAINTAINERS.md
• In .alexignore, ignore MAINTAINERS.md
• Run $ alex *.md

And you will get an error.

[fahad19]

Travis-CI build output for reference: https://travis-ci.org/Travix-International/frint/builds/231453498#L1895

[fahad19]

if I modify unified-engine/lib/finder.js:148 (link) a bit, it works like I expect it to:

if (ignored) {
  try {
    // file.fail('Cannot process specified file: it’s ignored');
  } catch (err) {}

  return one(null, []);
}

[wooorm]

Thanks for using alex, @fahad19, and hi!

This is intentional. Globs are expanded, and you’re saying like “get README.md and MAINTAINERS.md”, but then “don’t get MAINTAINERS.md”, and alex knows not what to do.

The simplest fix is probably to let alex find files itself: alex .
Could you check if that works?

[fahad19]

@wooorm: that worked! I will close this issue.

thanks for being so quick and helpful!

[wooorm]

Great! Sure, no problem, and glad to hear!

👋

[tymonx]

I want to re-open this issue because it still causes some issues in some cases.

Related:

• Files without file extension are not included for linting #338
• Hidden files started with dot are not included for linting #339
• The .alexrc.yml file should allow or deny words per selected file #340