Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden files started with dot are not included for linting #339

Closed
tymonx opened this issue Jun 24, 2023 · 1 comment
Closed

Hidden files started with dot are not included for linting #339

tymonx opened this issue Jun 24, 2023 · 1 comment
Labels
🚫 status/wontfix This is not (enough of) an issue for this project

Comments

@tymonx
Copy link

tymonx commented Jun 24, 2023

Subject of the issue

Hidden files started with dot . are not included for linting. Example: .hidden.

Your environment

  • OS: podman
  • Packages: podman run -it --rm registry.gitlab.com/pipeline-components/alex:0.21.9 --version
11.0.0
  • Env: podman run -it --rm registry.gitlab.com/pipeline-components/alex:0.21.9 env
NODE_VERSION=19.8.1
YARN_VERSION=1.22.19

Steps to reproduce

  1. Create hidden file that starts from dot .:
echo "pop" > .hidden
  1. Run alex:
podman run -it --rm --volume "$(pwd):/alex:ro,z" --workdir "/alex" registry.gitlab.com/pipeline-components/alex:0.21.9 --why .

Expected behaviour

It should return status code 1 and print:

.hidden
  1:1-1:4  warning  `pop` may be insensitive, use `parent` instead  dad-mom  retext-equality

⚠ 1 warning

Actual behaviour

It returns status code 0 (success) without printing anything to standard output or error output.

Workaround

Explicitly provide hidden files to alex (for example using shell glob pattern substitution .*):

podman run -it --rm --volume "$(pwd):/alex:ro,z" --workdir "/alex" registry.gitlab.com/pipeline-components/alex:0.21.9 --why .*

But this will not work when .alexignore is defined:

echo ".hidden" > .alexignore

It returns status code 1 and prints:

.alexignore: no issues found
.hidden
  1:1  error  Cannot process specified file: it’s ignored

✖ 1 error

Related issues

@wooorm
Copy link
Member

wooorm commented Jun 25, 2023

Hi!

It is intentional that dotfiles are not included by default.

If you want to include certain files, pass them: alex .hidden

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2023
@wooorm wooorm added the 🚫 status/wontfix This is not (enough of) an issue for this project label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 status/wontfix This is not (enough of) an issue for this project
Development

No branches or pull requests

2 participants