Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ improve create tests using fixtures #33

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Mar 25, 2024

Instead of using constant defined in the code of the test, we now use fixtures generated using our homemade tool that mock a webauthn authenticator.

Here's the link of the tool: webauthn-mock

Instead of using constant defined in the code of the test,
we now use fixtures generated using our homemade tool
that mock a webauthn authenticator.

Here's the link of the tool: [webauthn-mock](https://github.com/0x90d2b2b7fb7599eebb6e7a32980857d8/webauthn-mock)
@qd-qd qd-qd merged commit 31d29cc into main Mar 25, 2024
8 checks passed
@qd-qd qd-qd deleted the test/use-create-fixtures branch March 25, 2024 15:49
Copy link

Changes to gas cost

Generated at commit: daf7ab554b92463bf302c8f2e9b14468478d7365, compared to commit: faf33fe804a4b403034300e9cecf335b43abb586

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
WebAuthnWrapper _generateMessage
verify
-1,970 ✅
+3,721 ❌
-64.89%
+1.56%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
WebAuthnWrapper 1,465,171 (0) _generateMessage
verify
1,028 (0)
235,264 (-2,581)
0.00%
-1.09%
1,066 (-1,970)
241,566 (+3,721)
-64.89%
+1.56%
1,086 (-2,453)
241,582 (+3,737)
-69.31%
+1.57%
1,086 (-6,022)
247,871 (+10,026)
-84.72%
+4.22%
770 (-1)
101 (+100)
WebAuthn256r1Test 3,195,938 (-96,346)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant