-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issues when compiling ignores and .wokeignore not being applied #239
Comments
👋 Thanks for submitting your first issue! Please be sure to read and follow our Code of Conduct and Contributing guide. ⭐️ Is your org or open source project using |
I think the performance issues are caused by #117. An alternative possibly is to make this optional with a flag since we don't use nested ignores currently. |
Lots of bugs reported because of this feature 😞. Yea I like the idea of opt-in (suggested it too #117 (review)). Since it's already a feature, opt-out might be better to avoid breaking existing usages until improvements can be made to deal with these issues |
@armanrahman22 @KSLHacks @jeremydelacruz since you were all involved in the #117 I wonder if you would be interested at taking a stab at addressing these performance issues? |
@caitlinelfring sorry for the delay! Happy to come back to this and take a stab at it 🙂 |
Thank you for creating the issue!
Please include the following information:
Version of woke
Config file
No config file.
Go environment
Some characters omitted with *.
When running woke at the root of a large repository, it takes substantially longer to run due to searching for ignore files.
Running woke at the root of my repository (some text omitted with *):
vs running inside the some nested folders:
As you can see, it takes about a full 30 seconds each time woke runs to compile the ignores. The repository is quite large (about 400 GB) so this is an unusual use case. I'd also like to note that using woke version 0.17.1 does not have this issue.
Also could potentially be another issue, but I'm having troubles with .wokeignore not properly ignoring some paths in 0.19.0 which doesn't seem to occur in 0.17.1. It looks like directories specifically aren't properly ignored if you specify full paths, meaning a difference in running command line like this:
Not properly ignored and will find my test.txt with non-inclusive language:
T:\****>Tools\Woke\windows\woke.exe T:\****\Woke\windows
Properly ignored by .wokeignore:
T:\****>Tools\Woke\windows\woke.exe Tools\Woke\windows
The text was updated successfully, but these errors were encountered: