Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spf13/viper to manage config loading #39

Merged
merged 17 commits into from
Feb 10, 2021
Merged

Use spf13/viper to manage config loading #39

merged 17 commits into from
Feb 10, 2021

Conversation

caitlinelfring
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
Manual loading of configs via gopkg.in/yaml.v2

What is the new behavior (if this is a feature change)?
Switch to using https://github.com/spf13/viper to load configs. This opens up options of other file types in the future for defining configs. Also has a lot more really awesome features that work nicely with cobra

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No

Other information:

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #39 (3c99caa) into main (cb8dc31) will increase coverage by 0.43%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   95.44%   95.87%   +0.43%     
==========================================
  Files          19       19              
  Lines         461      461              
==========================================
+ Hits          440      442       +2     
+ Misses         12       11       -1     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
cmd/root.go 84.21% <90.00%> (+8.12%) ⬆️
pkg/config/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8dc31...3c99caa. Read the comment docs.

@caitlinelfring caitlinelfring merged commit 8917e8e into main Feb 10, 2021
@caitlinelfring caitlinelfring deleted the viper-config branch February 10, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant