-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use spf13/viper
to manage config loading
#39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 95.44% 95.87% +0.43%
==========================================
Files 19 19
Lines 461 461
==========================================
+ Hits 440 442 +2
+ Misses 12 11 -1
+ Partials 9 8 -1
Continue to review full report at Codecov.
|
caitlinelfring
force-pushed
the
viper-config
branch
from
November 11, 2020 03:14
08243a1
to
a395fb3
Compare
caitlinelfring
force-pushed
the
viper-config
branch
from
November 11, 2020 14:15
98dfc0f
to
ac27959
Compare
caitlinelfring
force-pushed
the
viper-config
branch
from
February 10, 2021 01:39
c7f15b8
to
c8b7a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Manual loading of configs via
gopkg.in/yaml.v2
What is the new behavior (if this is a feature change)?
Switch to using https://github.com/spf13/viper to load configs. This opens up options of other file types in the future for defining configs. Also has a lot more really awesome features that work nicely with cobra
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No
Other information: