Add "inclusion/exclusion" list of alternatives for white/black list #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitlinelfring
commented
May 5, 2021
| @@ -27,7 +27,7 @@ func (p *testPrinter) Print(_ io.Writer, r *result.FileResults) error { | |||
| } | |||
|
|
|||
| func testParser() *Parser { | |||
| return NewParser(rule.DefaultRules, ignore.NewIgnore([]string{})) | |||
| return NewParser([]*rule.Rule{&rule.TestRule}, ignore.NewIgnore([]string{})) | |||
There was a problem hiding this comment.
Using the default ruleset has the potential to break tests simply by updating a default rule. Using the test rule instead avoids this.
caitlinelfring
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Violations to whitelist now provides "inclusion list" as an alternative and to blacklist now provides "exclusion list" as an alternative.
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No
Other information:
Closes #65