Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Use github.com/caitlinelfring/go-env-default package #87

Merged
merged 2 commits into from
Jul 11, 2021

Conversation

caitlinelfring
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Switch from util package for accessing environment variables to a library: https://github.com/caitlinelfring/go-env-default

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)

Other information:

@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #87 (d0fc21f) into main (e6c5bed) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   96.21%   96.16%   -0.06%     
==========================================
  Files          21       20       -1     
  Lines         582      573       -9     
==========================================
- Hits          560      551       -9     
  Misses         13       13              
  Partials        9        9              
Impacted Files Coverage Δ
pkg/parser/parser.go 100.00% <100.00%> (ø)
pkg/printer/printer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c5bed...d0fc21f. Read the comment docs.

@caitlinelfring caitlinelfring merged commit 9eb558b into main Jul 11, 2021
@caitlinelfring caitlinelfring deleted the go-env-default branch July 11, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant