Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade flutter to 3.19.1 #2081

Merged
merged 4 commits into from Feb 28, 2024
Merged

chore: upgrade flutter to 3.19.1 #2081

merged 4 commits into from Feb 28, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Feb 22, 2024

resolves #1924

Note:

  1. The overall design changed slightly, I think whenever working on the UI we need to adjust minor things... or live with it that the color tone changed a bit.
  2. this does not upgrade flutter rust bridge which is a beast in itself

@bonomat
Copy link
Contributor Author

bonomat commented Feb 23, 2024

@holzeis : fixed the firefox issue in e43730f (#2081)

@holzeis
Copy link
Contributor

holzeis commented Feb 24, 2024

Two more things.

  • The payout chart doesn't fit anymore, throwing a layout error.
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during layout:
A RenderFlex overflowed by 40 pixels on the bottom.

The relevant error-causing widget was:
  Column
  Column:file:///Users/holzeis/workspace/coblox/10101/mobile/lib/features/welcome/payout_chart.dart:79:12

To inspect this widget in Flutter DevTools, visit:
http://127.0.0.1:9100/#/inspector?uri=http%3A%2F%2F127.0.0.1%3A56088%2FtVP8iz4aw_0%3D%2F&inspectorRef=inspector-0

The overflowing RenderFlex has an orientation of Axis.vertical.
The edge of the RenderFlex that is overflowing has been marked in the rendering with a yellow and
black striped pattern. This is usually caused by the contents being too big for the RenderFlex.
Consider applying a flex factor (e.g. using an Expanded widget) to force the children of the
RenderFlex to fit within the available space instead of being sized to their natural size.
This is considered an error condition because it indicates that there is content that cannot be
seen. If the content is legitimately bigger than the available space, consider clipping it with a
ClipRect widget before putting it in the flex, or using a scrollable container rather than a Flex,
like a ListView.
The specific RenderFlex in question is: RenderFlex#bded4 relayoutBoundary=up6 OVERFLOWING:
  creator: Column ← PnlLineChart ← FractionallySizedBox ← Expanded ← Column ← Expanded ← Column ←
    ConstrainedBox ← Container ← Transform ← Center ← AnimatedBuilder ← ⋯
  parentData: offset=Offset(0.0, 23.5) (can use size)
  constraints: BoxConstraints(0.0<=w<=390.0, h=188.2)
  size: Size(390.0, 188.2)
  direction: vertical
  mainAxisAlignment: spaceEvenly
  mainAxisSize: max
  crossAxisAlignment: center
  verticalDirection: down
◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤
════════════════════════════════════════════════════════════════════════════════════════════════════
  • The channel config modal is not moved when the keyboard is toggled.

Simulator Screenshot - iPhone 13 Pro - 2024-02-24 at 10 10 56

using the CanvasKit seems to make problems in the browser even though it's meant to provide better performance.

> CanvasKit renderer
> This renderer is fully consistent with Flutter mobile and desktop, has faster performance with higher widget density, but adds about 1.5MB in download size. CanvasKit uses WebGL to render Skia paint commands.

However, for us it just makes problems. We might want to revisit this decision in the future.

Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
@bonomat
Copy link
Contributor Author

bonomat commented Feb 24, 2024

@holzeis :

Two more things.

* The payout chart doesn't fit anymore, throwing a layout error.

I'm giving up on this :/ Might be better to spend some time replacing the carousel but I don't have the nerves for this right now.


    * The channel config modal is not moved when the keyboard is toggled.

This is fixed:

image

@bonomat bonomat closed this Feb 24, 2024
@bonomat bonomat reopened this Feb 24, 2024
@holzeis
Copy link
Contributor

holzeis commented Feb 24, 2024

I'm giving up on this :/ Might be better to spend some time replacing the carousel but I don't have the nerves for this right now.

Maybe this gets "fixed" if we switch back to the previous font and size.

@bonomat
Copy link
Contributor Author

bonomat commented Feb 24, 2024

Maybe this gets "fixed" if we switch back to the previous font and size.

Be my guest figuring out what it was before and setting it to this value now 🙈

to avoid overlapping of the position

Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
@holzeis
Copy link
Contributor

holzeis commented Feb 26, 2024

The small dots indicating that there is a carousel are also gone.

Screenshot 2024-02-26 at 09 57 07

Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just looking at the diff.

Although I was confused because I thought we were tackling #1777 haha.

child: Container(
padding: const EdgeInsets.all(18),
decoration: BoxDecoration(
borderRadius: BorderRadius.circular(8),
color: Colors.grey[100],
// color: Colors.grey[100],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I guess we can remove this.

@bonomat bonomat added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit bf48911 Feb 28, 2024
20 checks passed
@bonomat bonomat deleted the feat/flutter-upgrade branch February 28, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Flutter
3 participants