Upgrade Rust to version 1.76 #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade highlighted the fact that we were using `Node::connect` in two different ways: - Caring about the returned value, a future that will be ready once the connection is dropped. - Not caring about the returned value. Clippy was now complaining about us not always using the returned future. To fix this, I decided to split the API into two, so that the caller can be more explicit about what they want to do.
luckysori
force-pushed
the
chore/upgrade-rust-to-1-76
branch
from
06133bb
to
4d2f6dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade highlighted the fact that we were using
Node::connectin two different ways:Clippy was now complaining about us not always using the returned future. To fix this, I decided to split the API into two, so that the caller can be more explicit about what they want to do.