Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(channel offer): Reject a dlc channel offer if the processing fails #2157

Merged
merged 2 commits into from
Mar 5, 2024
Merged

chore(channel offer): Reject a dlc channel offer if the processing fails #2157

merged 2 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. chore(channel offer): Reject a dlc channel offer if the processing fa… 

    …ils.

Unlike rejecting a dlc channel offer if accepting fails, the `Channel::Offered` and `Contract::Offered` have not been stored to the dlc store.

Hence, there is no rust-dlc state to be cleaned up. Howerver, `rust-dlc` expects the `Channel::Offered` to be found by it's `dlc_channel_id`, which if it can't will fail the function.

This patch implements the reject soly on the application layer, but we might want to consider moving that code to rust-dlc`
    @holzeis
    holzeis committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9a176ef View commit details
    Browse the repository at this point in the history

  2. chore(offer): Reject failed settle and renew offers 

    The same logic applies for a failed `SettleOffer` and `RenewOffer`
    @holzeis
    holzeis committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3ac04be View commit details
    Browse the repository at this point in the history