feat(trade): Block users from trading with an old app version #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
changed the title
luckysori
reviewed
Mar 6, 2024
coordinator/migrations/2024-03-06-1135500_add_version_to_user/down.sql
Outdated
Show resolved
Hide resolved
luckysori
approved these changes
Mar 6, 2024
I opted to use the Cargo.toml version instead of the pubspec.yaml version as it is easier to access from rust and should probably anyways be bumped with every release. A minor downside of this is now that we have to different sources for the version. However, both versions are bumped by the same ci pipeline during `draft_new_release` - so eventually the source is the same.
We might want to consider simply bumping the versions of all crates instead of selectively bumping some.
holzeis
force-pushed
the
chore/block-users-from-trading-with-old-versions
branch
from
13ab779
to
a7e479b
Compare
holzeis
force-pushed
the
chore/block-users-from-trading-with-old-versions
branch
from
a7e479b
to
bb70acb
Compare
bonomat
reviewed
Mar 7, 2024
Comment on lines
+66
to
+70
| - name: Bump mobile/native Cargo.toml version | ||
| uses: stellar/binaries@v13 | ||
| with: | ||
| name: cargo-edit | ||
| version: 0.11.6 |
There was a problem hiding this comment.
❌ This step already exists a few lines above
bonomat
reviewed
Mar 7, 2024
| - id: set-mobile-version | ||
| continue-on-error: true | ||
| run: | | ||
| cargo set-version --package mobile/native ${{ github.event.inputs.version }} |
There was a problem hiding this comment.
❌ At least locally this does not work.
Correct would be
Suggested change
| cargo set-version --package mobile/native ${{ github.event.inputs.version }} | |
| cargo set-version --package native ${{ github.event.inputs.version }} |
There was a problem hiding this comment.
🙈 I tested it locally with a different command. Thanks for the fix 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted to use the Cargo.toml version instead of the pubspec.yaml version as it is easier to access from rust and should probably anyways be bumped with every release.
A minor downside of this is now that we have to different sources for the version. However, both versions are bumped by the same ci pipeline during
draft_new_release- so eventually the source is the same.Simulator.Screen.Recording.-.iPhone.15.-.2024-03-06.at.16.19.14.mp4
fixes #2141
fixes #1748