Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): add leverage slider #2178

Merged
merged 2 commits into from Mar 7, 2024
Merged

feat(webapp): add leverage slider #2178

merged 2 commits into from Mar 7, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Mar 7, 2024

Resolves #2154

Screen.Recording.2024-03-07.at.4.44.13.pm.mov

@bonomat
Copy link
Contributor Author

bonomat commented Mar 7, 2024

I'd be in favor of using the same slider in the app as well. I think it looks much better than the current with a gradient

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

)
],
)
/*Row(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I guess we can delete that code

This helps with smaller screens where we would otherwise have an overflow

Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
@bonomat bonomat enabled auto-merge March 7, 2024 08:17
@bonomat bonomat added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit e47519f Mar 7, 2024
9 checks passed
@bonomat bonomat deleted the feat/leverage-slider branch March 7, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a leverage cursor instead of a field
2 participants