Run DLC channels checks during wallet refresh #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past we were concerned about running all these tasks together, but after the `bdk` upgrade and the pivot away from Lightning there should be no problems. Also, any error that might occur during `sync_dlc_channels` is simply logged and does not interfere with updating the wallet history and balance. A nice consequence of this change is that if a user triggers a wallet refresh and a fund transaction or a collaborative close transaction is found to be confirmed, the corresponding channel should update automatically, ensuring that the app's state is up-to-date and ready to keep trading.
holzeis
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2082 1.
In the past we were concerned about running all these tasks together, but after the
bdkupgrade and the pivot away from Lightning there should be no problems. Also, any error that might occur duringsync_dlc_channelsis simply logged and does not interfere with updating the wallet history and balance.A nice consequence of this change is that if a user triggers a wallet refresh and a fund transaction or a collaborative close transaction is found to be confirmed, the corresponding channel should update automatically, ensuring that the app's state is up-to-date and ready to keep trading.
Footnotes
In my testing, I didn't find a problem that prevented the app from transitioning to the correct state. Instead, I noticed that it would take a longer time than necessary, which is why this PR is relevant. ↩