Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove periodic_chain_monitor #2212

Merged
merged 1 commit into from Mar 11, 2024
Merged

Conversation

luckysori
Copy link
Contributor

@luckysori luckysori commented Mar 11, 2024

Fixes #2205.

With the update to rust-dlc, we no longer need to run periodic_chain_monitor periodically, nor does rust-dlc have to process blocks independently of the our on-chain wallet.

Matching pull request in our rust-dlc fork: get10101/rust-dlc#14.


If the tests pass, I think this is okay :D

With the update to `rust-dlc`, we no longer need to run
`periodic_chain_monitor` periodically, nor does `rust-dlc` have to
process blocks independently of the our on-chain wallet.
@luckysori luckysori self-assigned this Mar 11, 2024
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luckysori luckysori added this pull request to the merge queue Mar 11, 2024
@holzeis holzeis removed this pull request from the merge queue due to a manual request Mar 11, 2024
@holzeis holzeis merged commit 1d19be7 into main Mar 11, 2024
21 checks passed
@holzeis holzeis deleted the fix/delete-periodic-chain-monitor branch March 11, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace rust-dlc's periodic_chain_monitor
2 participants