Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the two "install" buttons into one #3

Closed
bumi opened this issue Jan 9, 2022 · 2 comments · Fixed by #7
Closed

Combine the two "install" buttons into one #3

bumi opened this issue Jan 9, 2022 · 2 comments · Fixed by #7

Comments

@bumi
Copy link
Contributor

bumi commented Jan 9, 2022

Currently we first tell the use to install the browser extension (by opening the browser with a URL) and then to install the companion app.

We can actually combine that into one Button. We create the manifest JSON for that browser and then we open the browser with the install URL.

@stuffmc
Copy link
Collaborator

stuffmc commented Jan 9, 2022

Totally feasible. It doesn't mean people will install the extension though and maybe it's installed already, which we might check in the future and then not open the browser. Also, the extension probably does check that the companion has been installed, right?

@bumi
Copy link
Contributor Author

bumi commented Jan 9, 2022

Nice. yep, the extension then checks if the companion is installed.

This was referenced Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants