Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we have builds for all different platforms #6

Closed
bumi opened this issue Jan 11, 2022 · 7 comments
Closed

Make sure we have builds for all different platforms #6

bumi opened this issue Jan 11, 2022 · 7 comments

Comments

@bumi
Copy link
Contributor

bumi commented Jan 11, 2022

What do we need to do to make sure that the app runs on all recent macs (M1, Intel, recent OS versions)?
This is for the installer itself but also the companion executable. Do we need to deliver different executables for the different platforms?

@stuffmc
Copy link
Collaborator

stuffmc commented Jan 11, 2022

No.

@bumi
Copy link
Contributor Author

bumi commented Jan 11, 2022

@dylancom had the issue opening the app: "you can’t open alby because it’s not supported on this mac"
and I am not sure how the Rust app needs to be compiled.

@bumi
Copy link
Contributor Author

bumi commented Jan 27, 2022

the companion executable works on Intel and on M1.

we just need to make sure that the .app is available for intel and m1 and recent OS versions

@bumi bumi closed this as completed Jan 27, 2022
@bumi bumi reopened this Jan 27, 2022
@bumi
Copy link
Contributor Author

bumi commented Jan 27, 2022

so it actually seems we need to have two different executables depending on the platform. ?
need to see how to create a universal binary

https://stackoverflow.com/questions/66849112/how-do-i-cross-compile-a-rust-application-from-macos-x86-to-macos-silicon

what is lipo -create?

rust-lang/cargo#8875

@stuffmc
Copy link
Collaborator

stuffmc commented Jan 27, 2022

LOL what kind of old school technology is that? Can't it produce a universal binary?! Do I to change the "path" to, say, alby-intel or alby-arm? :) I can also probably make 2 executables/.app but that isn't the way a Mac is supposed to work.

@bumi
Copy link
Contributor Author

bumi commented Jan 27, 2022

chill, I just have to learn how to build the binaries.
you know web developers don't deal with this. :D
and btw. Rust is younger than Swift. :)

@bumi
Copy link
Contributor Author

bumi commented Jan 28, 2022

I don't know the macOS and Rust world very well, but I think we now got universal builds:
https://github.com/getAlby/alby-companion-rs#build

this release contains the latest version and should run on M1 + Intel: https://github.com/getAlby/alby-companion-rs/releases/tag/v0.5.0

@bumi bumi closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants