Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keysend payments in all the tipping features #792

Open
bumi opened this issue Apr 13, 2022 · 0 comments
Open

Support keysend payments in all the tipping features #792

bumi opened this issue Apr 13, 2022 · 0 comments
Labels
enhancement New feature or request ready ready to be worked on

Comments

@bumi
Copy link
Collaborator

bumi commented Apr 13, 2022

Is your feature request related to a problem? Please describe.
Currently we support sending tips through lnurl/lightning addresses. People have to have lightning address and add that one to their social media profiles (Youtube, GitHub, Twitter, etc.)
This leaves out users who do not support LNURL.

Describe the solution you'd like
Additionally to LNURL payments we can also support keysend payments. Users then can either provide a lightning address OR a node pubkey in their profiles.
Alby checks if it is a pubkey and uses keysend otherwise it uses the current lnurl pay flow.

We would need to adjust the regex in all the batteries (e.g. https://github.com/getAlby/lightning-browser-extension/blob/master/src/extension/content-script/batteries/GitHub.ts#L21)

In the lightning data we already have the method key which is currently hard-coded to lnurl: https://github.com/getAlby/lightning-browser-extension/blob/master/src/extension/content-script/batteries/GitHub.ts#L42

For keysend data we would probably need to navigate to the keysend screen: https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/screens/Home/index.tsx#L100-L115

(alternatively we could think of a new special tipping screen?)

@bumi bumi added the enhancement New feature or request label Apr 13, 2022
@bumi bumi added the ready ready to be worked on label May 18, 2022
@escapedcat escapedcat changed the title Support keysend payments in all the tipping features. Support keysend payments in all the tipping features Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready ready to be worked on
Projects
Status: 📝 To-Do
Development

No branches or pull requests

1 participant