Capture links in dynamic content #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep stacking sats! |
bumi
reviewed
Aug 31, 2022
escapedcat
reviewed
Aug 31, 2022
bumi
reviewed
Sep 6, 2022
src/extension/inpage-script/index.js
Outdated
| (ev) => { | ||
| // Use composedPath() for detecting links inside a Shadow DOM | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath | ||
| const target = ev.composedPath()[0] || ev.target; |
There was a problem hiding this comment.
is ev.composedPath() always returning an array?
There was a problem hiding this comment.
According to the docs, yes:
I currently can't think of a case where composedPath is null. I'll test and remove the old |
reneaaron
force-pushed
the
feature/capture-links-in-dynamic-content
branch
from
063cdd1
to
a608656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Capture ALL
lightning:links.Link this PR to an issue
#1307
Type of change (Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)Checklist