Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishers blank state #88

Closed
bumi opened this issue Jun 29, 2021 · 15 comments
Closed

Publishers blank state #88

bumi opened this issue Jun 29, 2021 · 15 comments
Labels
design Requires design work enhancement New feature or request frontend All things frontend development related

Comments

@bumi
Copy link
Collaborator

bumi commented Jun 29, 2021

What do we show on the publishers page when a user does not yet has configured any allowances?
Maybe: an explanation what an allowance is and a link to a demo publisher (as after the onboarding screen)

@bumi bumi added enhancement New feature or request design frontend All things frontend development related labels Jun 29, 2021
@MoritzKa MoritzKa linked a pull request Feb 20, 2022 that will close this issue
@MoritzKa
Copy link
Contributor

so this is not the website screen, but this one:
image

@bumi
Copy link
Collaborator Author

bumi commented Feb 20, 2022

I think the website screen. (your screenshot shows the details page of a publisher/website)

image

@MoritzKa
Copy link
Contributor

If you mean the "Websites" screen then we can link: #490
but also single publisher/websites pages still look quite empty (s. screenshot in my previous comment)

@secondl1ght
Copy link
Contributor

Is there a design for this screen?

@bumi
Copy link
Collaborator Author

bumi commented Mar 15, 2022

I think there are screens somewhere (in Figma?) but the screens in the PR are fine. we just should make sure it's simple code. in the end we just want to show some boxes listed :)

@secondl1ght
Copy link
Contributor

Ok maybe I can rewrite it from scratch then? Is there a list of websites we want to show here?

@MoritzKa
Copy link
Contributor

https://www.figma.com/file/xEPJFGFdc3HD0JS1ax2IpH/Extension-(MVP)?node-id=2711%3A16621
image

@secondl1ght
Copy link
Contributor

Cool thanks @MoritzKa! @bumi do you think I should use the code in PR #490 or start over?

@secondl1ght
Copy link
Contributor

Another option would be to just link to makers.bolt.fun here because they already have this setup?

@MoritzKa
Copy link
Contributor

I would prefer to have these websites directly in Alby
1.) We can test "marketplace" functionalities with users
2.) We are independent from directories

regarding code, maybe @dylancom can give some advise.

@bitcoinuser
Copy link
Contributor

I would like to see something like this too: https://feedback.getalby.com/feature-requests-/posts/store-sites-that-alby-users-used-to-make-payments

@im-adithya
Copy link
Member

Can I work on this?

@escapedcat
Copy link
Contributor

Can I work on this?

I think this is (mostly?) covered by #490 but got stuck. Further above @secondl1ght already mentioned to work on it.

@secondl1ght
Copy link
Contributor

If you want to give this a try you can go ahead @im-adithya, it was in my backlog of things to do.

@MoritzKa MoritzKa added design Requires design work and removed design labels Oct 13, 2022
@stackingsaunter
Copy link
Contributor

Outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Requires design work enhancement New feature or request frontend All things frontend development related
Projects
None yet
Development

No branches or pull requests

7 participants