Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mitigate that always have to update irsa s3_object #110

Merged

Conversation

soem
Copy link
Contributor

@soem soem commented Mar 11, 2021

  • Fixed:
    • Use the file() with fileexists() to avoid read from the unstable data.local_file source.
      • If file doesn't exist, fallback to the data.local_file source.
  • Potential Issues:
    • The s3_object might be incorrect if the keys.json has been changed externally.
      • run apply again might not fix this case, since the null_resource triggers cannot handle this issue,
      • delete the keys.json file might be the only way.
    • The trigger local_cache_exist of null_resource would keep wrong states, and trigger local file updating.
      • from scratch => local_cache_exist: null -> false
      • run again => local_cache_exist: false -> true
      • run again => local_cache_exist: true

@soem soem changed the title FEATURE: mitigate that always have to update irsa s3_object feat: mitigate that always have to update irsa s3_object Mar 11, 2021
@smalltown smalltown merged commit 6be6a8f into getamis:master Mar 12, 2021
@soem soem deleted the poc/avoid-always-have-to-update-irsa-s3-object branch March 12, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants