Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor aws and ignition modules #74

Merged
merged 21 commits into from
Jul 24, 2020
Merged

Refactor aws and ignition modules #74

merged 21 commits into from
Jul 24, 2020

Conversation

kairen
Copy link
Contributor

@kairen kairen commented Jul 6, 2020 •
edited

  • Refactor etcd.
  • Kubernetes igntions
    • Refactor kubelet.
    • TLS bootstrapping.
    • etcd data encryption.
    • Make Kubernetes components are a bit more secure.
    • Remove deprecated function.
    • Update addons.
    • Remove deprecated hyperkube.
  • aws
    • Refactor master.
    • Refactor worker

@kairen kairen added do-not-merge/work-in-progress PR is work in progress, don not merge it. kind/feature New feature and request. labels Jul 6, 2020
@kairen kairen requested a review from smalltown July 6, 2020 02:15
@kairen kairen changed the title Refactor Kubernetes ignition modules Refactor Kubernetes and etcd modules Jul 10, 2020
@kairen kairen force-pushed the kyle/refactor-kubernetes branch 5 times, most recently from 7d95ea0 to 8f26685 Compare July 13, 2020 18:05
@kairen
Copy link
Contributor Author

kairen commented Jul 14, 2020

Remove hyperkube. refer: kubernetes/kubernetes#88676.

@kairen kairen changed the title Refactor Kubernetes and etcd modules WIP: refactor Kubernetes and etcd modules Jul 16, 2020
@kairen kairen changed the title WIP: refactor Kubernetes and etcd modules WIP: Refactor Kubernetes and etcd modules Jul 16, 2020
@kairen kairen changed the title WIP: Refactor Kubernetes and etcd modules Refactor aws and ignition modules Jul 17, 2020
@kairen kairen added enhancement New feature or request v0.1.0 v0.1.0 and removed do-not-merge/work-in-progress PR is work in progress, don not merge it. labels Jul 17, 2020
smalltown
smalltown reviewed Jul 18, 2020
View reviewed changes
Copy link
Contributor

@smalltown smalltown left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For the kubelet, kubectl, and cni binary download, could we use ignition_file, instead of curl, since curl only support http protocol, but ignition_file support http, https, tftp, s3, and data
  • The iam-auth kubeconfig default value need to change to admin.conf
  • The circleci (run-kubernetes-cluster) fail due to remove unexist ssh key pair

smalltown
smalltown previously approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@smalltown smalltown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful 👍

smalltown
smalltown approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@smalltown smalltown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kairen kairen merged commit 57800c9 into getamis:master Jul 24, 2020
@kairen kairen deleted the kyle/refactor-kubernetes branch October 20, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalltown smalltown smalltown approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request kind/feature New feature and request. v0.1.0 v0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kairen @smalltown