This repository has been archived by the owner on May 27, 2022. It is now read-only.
WIP: v2 impl #129
Merged
WIP: v2 impl #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -0,0 +1,21 @@ | |||
package project | |||
|
|||
func NewLocal(folder string) Project { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function NewLocal should have comment or be unexported
return Event{Error: err} | ||
} | ||
|
||
func Shell(shell string) Event { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function Shell should have comment or be unexported
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #128
This is a full rewrite of the core APIs, now we have:
--static
is now the default (the only broker api change). Basically, everything passed down tobundle
will return asource path
orexport PATH=blah
or whatever theProject
impl doesWhats missing:
This will be
v2.0.0
. Actualv0.9.x
will be promoted tov1.0.0
and for now on will receive only bugfixes