Skip to content
This repository has been archived by the owner on May 27, 2022. It is now read-only.

fix: multiple oh-my-zsh plugins behavior #244

Merged
merged 9 commits into from Jul 13, 2018
Merged

fix: multiple oh-my-zsh plugins behavior #244

merged 9 commits into from Jul 13, 2018

Conversation

caarlos0
Copy link
Member

closes #238

still checking the performance of that.

@caarlos0
Copy link
Member Author

maybe a better approach would be to allow multiple folder declarations... and it won't require this additional lock...

@Dessix
Copy link

Dessix commented Jul 13, 2018

That sounds more straight-forward.

@codecov-io
Copy link

codecov-io commented Jul 13, 2018

Codecov Report

Merging #244 into master will increase coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   79.11%   79.44%   +0.33%     
==========================================
  Files          11       11              
  Lines         249      253       +4     
==========================================
+ Hits          197      201       +4     
  Misses         49       49              
  Partials        3        3
Impacted Files Coverage Δ
project/git.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9ed6c...ff1b183. Read the comment docs.

@caarlos0
Copy link
Member Author

the code end up being messier and performance worse.

other downside is that you can't have custom kind for each plugin (i.e. want one folder to be path and the other zsh).

will roll back to the locking version.

@caarlos0 caarlos0 merged commit 6466ad1 into master Jul 13, 2018
@caarlos0 caarlos0 deleted the oh-my-zsh branch July 13, 2018 05:40
@Dessix
Copy link

Dessix commented Jul 13, 2018

The fix works great, thanks 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add more than 1 plugin from oh-my-zsh
3 participants