This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Remove support for Node 14 #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remember to also change the docs to remove Node 14 as a supported platform. |
dividedmind
force-pushed
the
remove-node-14
branch
from
f17b346
to
34252c0
Compare
lachrist
suggested changes
Jul 18, 2023
There was a problem hiding this comment.
There is some additional cleanup to do. On top of my head there is the old format of the node loader api -- eg:
appmap-agent-js/lib/node/loader-esm.mjs
Line 49 in e876f95
Sure, go for it! I tried to find everything but I'm sure I missed a couple places. |
dividedmind
force-pushed
the
ci/move-to-github-actions
branch
from
92b7d09
to
614b0f7
Compare
dividedmind
force-pushed
the
ci/move-to-github-actions
branch
from
ae0954b
to
14f61ff
Compare
dividedmind
force-pushed
the
remove-node-14
branch
from
34252c0
to
b81a450
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official support ended on 2023-04-30.