Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LookDev transfer Error #42

Closed
CalleHalldin opened this issue Feb 9, 2017 · 8 comments
Closed

LookDev transfer Error #42

CalleHalldin opened this issue Feb 9, 2017 · 8 comments
Assignees

Comments

@CalleHalldin
Copy link

Example move
Process to get to produce the bug:

  • Create a model for assetA.
  • Create a lookDev for assetA.
  • Create model assetB.
  • Create lookDev for assetB.
  • Load ModelA and Lookdev into a new scene
  • Load ModelB and Lookdev into same scene
  • Load Lookdev for ModelA again and it will get the ModelB lookDev and it can't be changed back with the loader.

Seems like its always the First models and lookDev that you load that transfers the shader to the wrong asset. As can be seen in the video even though I create a completely new scene the bug is still there.

@mottosso
Copy link
Contributor

mottosso commented Feb 9, 2017

Thanks @CalleHalldin, having a look at this tomorrow morning. Make sure the steps to reproduce does reproduce the problem, that way it'll be much quicker to fix.

@mottosso
Copy link
Contributor

Sorry I haven't gotten into this yet.

@LegacyID1991, you might be able to dive into this. The problem must be somewhere in the loader for this family, see here.

I would start printing things, and see if you can pinpoint where in the loader the problem occurs. Likely in the maya.apply_shaders function. If you print the relationships variable, it'll give you a dictionary. You can use that dictionary to manually call apply_shaders and debug from there.

@mottosso
Copy link
Contributor

@LegacyID1991 Did you have a look at this? If not, let me know here so I know whether I should look at it.

@LegacyID1991
Copy link
Contributor

I am sorry to say that I have been so slammed with other work duties that I haven't gotten to this one yet.

@mottosso
Copy link
Contributor

That's ok, I just need to know whether I should look into it so we don't work on it at the same time. Would you like me to take over?

@LegacyID1991
Copy link
Contributor

go right ahead.
😄

@mottosso mottosso assigned mottosso and unassigned LegacyID1991 Feb 17, 2017
@mottosso
Copy link
Contributor

Ok, I've found the problem.

The problem is that it assigns to meshes based on the name of the shader group, but if the shader group has the same name in both look dev publishes, such as blinn1SG, the it gets confused and assigns the wrong one.

Putting together a fix now.

@mottosso mottosso mentioned this issue Feb 17, 2017
@mottosso
Copy link
Contributor

Fixed, @LegacyID1991 is updating the pipeline shortly.

tokejepsen pushed a commit to tokejepsen/core that referenced this issue Jun 24, 2019
…le_reversed_order

listdir is alphabetically reversed so higher version is first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants