-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci coverage & azure #559
Conversation
@@ -54,7 +54,7 @@ jobs: | |||
|
|||
- job: MacOS | |||
pool: | |||
vmImage: "macOS-10.13" # High-Sierra | |||
vmImage: "macOS-10.15" # Catalina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
cec3617
to
62c47b0
Compare
62c47b0
to
6093310
Compare
We need to pin it at this version since the newer version has refactored `Reporter` class which not yet adopted by `python-coveralls`..
About the error message which @tokejepsen mentioned in review: $ coveralls
Submitting coverage to coveralls.io...
Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs This reminds me what happened in #494, looks like it was the same cause. So the reason to that error was because the Turns out the problem was in the Coveralls's python integration module. I have changed to use coveralls-clients/coveralls-python ( And with coveralls-clients/coveralls-python integration, it just won't get the coveralls repo token. Because I tried Anyway, I changed back to the z4r/python-coveralls integration, which requires to pin
Maybe it will be gone in the merge commit ? Not sure. |
I saw the error, and had a look at coveralls.io, and indeed it does not exist. :O I think GitHub updated the permission features a while back, and it looks like Coveralls got left out. I've added it now and updated the repo token, and expect it will work. For both PRs and merges. Let's give it a try, and if not switch to something else. |
Well, it does work, but not really. |
Looks like there was a problem when combining coverage data
https://travis-ci.org/github/getavalon/core/jobs/713255428#L683 I guess.., it was because we are foced to use outdated So many pitfall after Python 2.7 being rejected :( Maybe |
Ah, sorry, maybe it's because I forgot to pin Which makes the older version |
What's changed
This PR fix #558.
The code coverage submission was decoupled from maya test script, and provide a new scheme for future testing on multiple DCC tools or versions.
New code coverage scheme
.coverage
data file after complete..coverage
into.coverage.{subject}
, where the subject could be DCC tool name and version.coverage combine
to combine all.coverage
prefixed data file into one.