Add sequence alias for collect, custom NoSuchElementException message… #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, update developers list
| } | ||
| "seq" in { | ||
| val clumps = Seq(Clump.value(1), Clump.value(2)) | ||
| clumpResult(Clump.sequence(clumps)) mustEqual Some(Seq(1, 2)) |
There was a problem hiding this comment.
it seems to be missing a test for the varargs overload
Clump.sequence(clump1, clump2)
|
@fwbrasil @williamboxhall forgot that I hadn't pushed this yet. Any comments? |
|
👍 |
1 similar comment
|
👍 |
fwbrasil
added a commit
that referenced
this pull request
Aug 20, 2015
Add sequence alias for collect, custom NoSuchElementException message…
|
@stevenheidel Could you make the release for this change? Let me know if you need help with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, update developers list