Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default include guard doesn't convert hyphens #86

Closed
Karrq opened this issue Mar 2, 2022 · 0 comments · Fixed by #87
Closed

Default include guard doesn't convert hyphens #86

Karrq opened this issue Mar 2, 2022 · 0 comments · Fixed by #87
Labels
K-bug Kind: existing code isn’t behaving as expected M-good-first-issue Marker: good first issue to get familiar with the code

Comments

@Karrq
Copy link

Karrq commented Mar 2, 2022

Hi, first of all thanks for the awesome work!

Now, during the use of this library I noticed that my generated header include guard was taking the name I put on the crate manifest and using it but leaving the hyphens as is.

For example, a crate named my-awesome-crate, using the default builder, would generate a header with the include guard __RUST_MY-AWESOME-CRATE__
@danielhenrymantilla danielhenrymantilla added 2022-Q1 K-bug Kind: existing code isn’t behaving as expected M-good-first-issue Marker: good first issue to get familiar with the code labels Mar 2, 2022
danielhenrymantilla added a commit that referenced this issue Mar 2, 2022
@danielhenrymantilla
Fix incorrect C header guard when the PKG_NAME contains hyphens
fee31f5 
Fixes #86
@danielhenrymantilla danielhenrymantilla mentioned this issue Mar 2, 2022
Merged
danielhenrymantilla added a commit that referenced this issue Mar 2, 2022
@danielhenrymantilla
Fix incorrect C header guard when the PKG_NAME contains hyphens
a3b62ca 
Fixes #86
danielhenrymantilla added a commit that referenced this issue Mar 2, 2022
@danielhenrymantilla
Fix incorrect C header guard when the PKG_NAME contains hyphens
5d5b3d8 
Fixes #86
danielhenrymantilla added a commit that referenced this issue Mar 2, 2022
@danielhenrymantilla
Fix incorrect C header guard when the PKG_NAME contains hyphens
0575aa4 
Fixes #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
K-bug Kind: existing code isn’t behaving as expected M-good-first-issue Marker: good first issue to get familiar with the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect C header guard when the PKG_NAME contains hyphens getditto/safer_ffi
2 participants
@Karrq @danielhenrymantilla