96 export enum constant which are not used by a function call #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffi_export can now be applied to enums.
danielhenrymantilla
approved these changes
May 5, 2022
README.md
Outdated
| @@ -78,6 +78,15 @@ fn mid_point(a: &Point, b: &Point) -> Point { | |||
| } | |||
| } | |||
|
|
|||
| /* Export a Rust enum to C */ | |||
| #[ffi_export] | |||
There was a problem hiding this comment.
Suggested change
| #[ffi_export] | |
| #[ffi_export] // directly exporting a type is only needed | |
| // if no exported function mentions is |
ronan-ditto
deleted the
96-export-enum-constant-which-are-not-used-by-a-function-call
branch
This was referenced May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi_export can now be applied to enums.
Furthermore Readme.md has been updated accordingly.