Fix: Incorrect format of PHPCS for *register custom sanitize function* #2286
Conversation
WalkthroughThis update involves modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- phpcs.xml.dist (1 hunks)
Additional comments not posted (4)
phpcs.xml.dist (4)
Line range hint
1-1: Ensure XML declaration is present and correctly formatted.
Line range hint
1-1: Review the overall structure and formatting of the XML file to ensure it adheres to best practices.
Line range hint
1-1: Check that the file includes all necessary configurations and rules for the WordPress coding standards.
Line range hint
1-1: Verify that thecustomSanitizingFunctionsproperty update is correctly implemented.Verification successful
The
dokan_sanitize_phone_numberfunction is integrated properly across the codebase, as evidenced by its usage in multiple relevant PHP files.
templates/settings/store-form.phptemplates/account/update-customer-to-vendor.phpincludes/template-tags.phpincludes/functions.phpincludes/Registration.phpincludes/Frontend/MyAccount/BecomeAVendor.phpincludes/Dashboard/Templates/Settings.phpincludes/Admin/UserProfile.phpScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new sanitizing function is integrated properly across the codebase. # Test: Search for the function usage. Expect: Occurrences of the new function in relevant PHP files. rg --type php $'dokan_sanitize_phone_number'Length of output: 1269
update: actions with latest version
added: custom capabilities for vendors and admin from dokan
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/phpcs.yml (1 hunks)
- phpcs.xml.dist (4 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/phpcs.yml
Files skipped from review as they are similar to previous changes (1)
- phpcs.xml.dist
mralaminahamed
deleted the
fix/phpcs-custom-sanitize-fuction-registration-incorrect-format
branch
All Submissions:
Changes proposed in this Pull Request:
fix: Incorrect format of PHPCS for register custom sanitize function
Related Pull Request(s)
Closes
Ref
How to test the changes in this Pull Request:
Changelog entry
Fix: Incorrect format of PHPCS for register custom sanitize function
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit
Chores
Refactor
customSanitizingFunctionsto an array type.dokan_sanitize_phone_numberand removedwc_cleanfrom sanitizing functions.