Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: u128 and i128 Field and FieldType #1315

Merged
merged 31 commits into from
Apr 4, 2023

Conversation

chloeminkyung
Copy link
Contributor

@chloeminkyung chloeminkyung commented Mar 27, 2023

  • implementation
  • unit tests

Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@chloeminkyung chloeminkyung marked this pull request as draft March 27, 2023 09:13
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@chloeminkyung chloeminkyung linked an issue Mar 27, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Mar 27, 2023

Pull Request Test Coverage Report for Build 4606035459

  • 1641 of 2877 (57.04%) changed or added relevant lines in 28 files are covered.
  • 1089 unchanged lines in 48 files lost coverage.
  • Overall coverage decreased (-2.2%) to 72.358%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-api/src/generator/protoc/generator/implementation.rs 0 2 0.0%
dozer-api/src/rest/api_generator.rs 0 2 0.0%
dozer-sql/src/pipeline/expression/python_udf.rs 0 2 0.0%
dozer-sql/src/pipeline/expression/tests/cast.rs 153 155 98.71%
dozer-api/src/generator/oapi/generator.rs 0 3 0.0%
dozer-api/src/grpc/typed/helper.rs 0 3 0.0%
dozer-types/src/arrow_types/to_arrow.rs 0 3 0.0%
dozer-api/src/generator/oapi/utils.rs 0 4 0.0%
dozer-cache/src/cache/lmdb/cache/main_environment/mod.rs 0 4 0.0%
dozer-ingestion/tests/test_suite/basic.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
dozer-api/src/grpc/internal/internal_pipeline_client.rs 1 62.3%
dozer-cache/src/cache/lmdb/indexing.rs 1 86.52%
dozer-storage/src/lmdb_multimap.rs 1 79.8%
dozer-cache/src/cache/lmdb/cache/main_environment/mod.rs 2 87.03%
dozer-ingestion/src/connectors/kafka/debezium/schema.rs 2 97.98%
dozer-sql/src/pipeline/expression/scalar/number.rs 3 44.93%
dozer-sql/src/pipeline/expression/logical.rs 4 59.09%
dozer-sql/src/pipeline/expression/tests/mathematical.rs 4 90.66%
dozer-sql/src/pipeline/expression/datetime.rs 5 64.71%
dozer-sql/src/pipeline/expression/python_udf.rs 5 66.67%
Totals Coverage Status
Change from base Build 4603408214: -2.2%
Covered Lines: 33525
Relevant Lines: 46332

💛 - Coveralls

Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@chloeminkyung chloeminkyung removed the request for review from mediuminvader March 30, 2023 06:34
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@chloeminkyung chloeminkyung marked this pull request as ready for review April 2, 2023 15:57
@chloeminkyung chloeminkyung requested a review from v3g42 April 3, 2023 03:56
@snork-alt snork-alt requested a review from chubei April 3, 2023 09:54
Copy link
Contributor

@chubei chubei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Support looks fine inside dozer. I have some questions about conversions listed in the comments.

dozer-api/src/grpc/types_helper.rs Show resolved Hide resolved
dozer-ingestion/tests/test_suite/connectors/arrow.rs Outdated Show resolved Hide resolved
dozer-ingestion/tests/test_suite/connectors/arrow.rs Outdated Show resolved Hide resolved
dozer-types/src/helper.rs Show resolved Hide resolved
# Conflicts:
#	dozer-orchestrator/src/pipeline/sinks.rs
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@chubei
Copy link
Contributor

chubei commented Apr 4, 2023

Please also update the table in dozer-api/README.md.

Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Copy link
Contributor

@chubei chubei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update dozer-api/README.md and we're good to go!

Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
dozer-api/README.md Outdated Show resolved Hide resolved
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
@chubei chubei merged commit 611912e into getdozer:main Apr 4, 2023
@chloeminkyung chloeminkyung deleted the feat/u128_i128 branch April 4, 2023 09:39
karolisg added a commit to getdozer/dozer-js that referenced this pull request Apr 7, 2023
Changes made in dozer repo - getdozer/dozer#1315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

u128, i128 support for Duration
5 participants