-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: u128 and i128 Field and FieldType #1315
Conversation
chloeminkyung
commented
Mar 27, 2023
•
edited
Loading
edited
- implementation
- unit tests
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Support looks fine inside dozer. I have some questions about conversions listed in the comments.
# Conflicts: # dozer-orchestrator/src/pipeline/sinks.rs
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Please also update the table in |
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update dozer-api/README.md
and we're good to go!
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Signed-off-by: Chloe Kim <chloeminkyung@gmail.com>
Changes made in dozer repo - getdozer/dozer#1315