Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update resolution atomicity and stream operations. #1390

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

chubei
Copy link
Contributor

@chubei chubei commented Apr 6, 2023

Fixes #1368.
Fixes #1288.

@chubei chubei requested a review from karolisg April 6, 2023 14:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4629946481

  • 589 of 739 (79.7%) changed or added relevant lines in 11 files are covered.
  • 227 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.7%) to 72.631%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-cache/src/cache/mod.rs 4 5 80.0%
dozer-types/src/models/api_endpoint.rs 0 1 0.0%
dozer-cache/src/cache/lmdb/tests/basic.rs 14 19 73.68%
dozer-cache/src/cache/lmdb/cache/main_environment/operation_log/lmdb_val_impl.rs 11 22 50.0%
dozer-cache/src/cache/lmdb/cache/main_environment/operation_log/mod.rs 200 230 86.96%
dozer-api/src/cache_builder/mod.rs 24 59 40.68%
dozer-cache/src/cache/lmdb/cache/main_environment/mod.rs 91 158 57.59%
Files with Coverage Reduction New Missed Lines %
dozer-sql/src/pipeline/projection/processor.rs 1 98.15%
dozer-types/src/models/api_endpoint.rs 1 13.97%
dozer-cache/src/cache/lmdb/tests/basic.rs 4 91.89%
dozer-core/src/dag_checkpoint.rs 4 90.0%
dozer-cache/src/cache/index/mod.rs 5 94.05%
dozer-core/src/executor/source_node.rs 5 94.74%
dozer-orchestrator/src/lib.rs 5 12.5%
dozer-cache/src/cache/lmdb/cache/query/handler.rs 10 91.8%
dozer-cache/src/cache/lmdb/cache/query/tests.rs 14 95.02%
dozer-cache/src/cache/lmdb/cache/mod.rs 18 82.64%
Totals Coverage Status
Change from base Build 4628159079: 0.7%
Covered Lines: 34521
Relevant Lines: 47529

💛 - Coveralls

Copy link
Contributor

@karolisg karolisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chubei chubei merged commit 676c73b into getdozer:main Apr 6, 2023
@chubei chubei deleted the fix/upsert branch April 6, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix conflict resolution implementation and tests. Wrong streamed event when insert policy is update
3 participants