Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: All nodes use the same instant for commit timeout #807

Merged
merged 1 commit into from
Feb 6, 2023
Merged

feat: All nodes use the same instant for commit timeout #807

merged 1 commit into from
Feb 6, 2023

Conversation

chubei
Copy link
Contributor

@chubei chubei commented Feb 6, 2023

Closes #806

@chubei chubei requested a review from snork-alt February 6, 2023 03:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4100188013

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 66.217%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-core/src/dag/epoch.rs 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
dozer-core/src/dag/executor/source_node.rs 3 97.6%
dozer-core/src/dag/epoch.rs 26 73.17%
Totals Coverage Status
Change from base Build 4099856745: 0.06%
Covered Lines: 24540
Relevant Lines: 37060
💛 - Coveralls

@snork-alt snork-alt merged commit 2203cbb into getdozer:main Feb 6, 2023
@chubei chubei deleted the feat/instant branch February 9, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snork-alt snork-alt snork-alt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return timeout sentry from epoch manager to the sources so they timeout at the same instant
3 participants
@chubei @coveralls @snork-alt