enhancement: replace HOST_DOMAIN with BASE_URL #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOST_DOMAIN was introduced to avoid host attack, where an attacked could intercept the request, modify the Host header and Fider would send an email with a link using the hijacked Host domain. But this variable introduce multiple problems, for one, it's difficult to use in Kubernetes or behind any cloud load balancer.
This PR replaces it with BASE_URL, which is used when sending emails, but does not have any interference with the HTTP pipeline, meaning that Fider can be hosted on ANY url/port.