Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: docker healthcheck #371

Merged
merged 8 commits into from Apr 30, 2018
Merged

enhancement: docker healthcheck #371

merged 8 commits into from Apr 30, 2018

Conversation

goenning
Copy link
Member

Issue: closes #363

  • implements docker health check
  • remove unused endpoints
  • adds /-/health

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #371 into master will decrease coverage by 0.58%.
The diff coverage is 12.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   73.03%   72.45%   -0.58%     
==========================================
  Files          74       76       +2     
  Lines        4765     4766       +1     
==========================================
- Hits         3480     3453      -27     
- Misses       1031     1059      +28     
  Partials      254      254
Impacted Files Coverage Δ
main.go 0% <0%> (ø) ⬆️
app/cmd/ping.go 0% <0%> (ø)
app/cmd/server.go 0% <0%> (ø)
app/pkg/web/engine.go 50% <100%> (ø) ⬆️
app/cmd/routes.go 100% <100%> (ø)
app/handlers/common.go 66.67% <50%> (-15.83%) ⬇️
app/pkg/log/logger.go 52.83% <0%> (-7.55%) ⬇️
app/pkg/web/context.go 78.72% <0%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4773afa...3bed14e. Read the comment docs.

@goenning goenning merged commit 0c455e3 into master Apr 30, 2018
@goenning goenning deleted the docker-healthcheck branch April 30, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include HealthCheck on Docker images
2 participants