Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle invalid ServerNames during SSL handshake #689

Merged
merged 6 commits into from Dec 19, 2018

Conversation

goenning
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #689 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   64.68%   64.93%   +0.25%     
==========================================
  Files         111      111              
  Lines        8790     8796       +6     
==========================================
+ Hits         5685     5711      +26     
+ Misses       2623     2600      -23     
- Partials      482      485       +3
Impacted Files Coverage Δ
app/pkg/web/ssl.go 84.91% <100%> (+40.22%) ⬆️
app/pkg/dbx/dbx.go 84.46% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5480aa...490a679. Read the comment docs.

@goenning goenning merged commit 0faad5b into master Dec 19, 2018
@goenning goenning deleted the handle-invalid-servernames branch December 21, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants