Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extraneous quote in schema_dumper #1

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

pedantic-git
Copy link
Contributor

Thanks for this great extension!

There's a slight typo in the schema dumper that's causing syntax errors for me. This PR just removes the extraneous " symbol from that line.

@pedantic-git
Copy link
Contributor Author

Hi @alassek - may I enquire as to the status of this PR from October? Hopefully it's a pretty minor thing and I'd love to have it released in the upstream gem.

@alassek alassek merged commit ce00b5a into alassek:master Feb 21, 2019
@alassek
Copy link
Owner

alassek commented Feb 21, 2019

@pedantic-git Hi there, I have not officially released this yet because I wanted to support previous versions of Rails, but if you're on 5.2 it should be fully functional. I have been working on support for earlier versions, but they made a lot of structural changes in the code for 5.2 unfortunately.

@pedantic-git
Copy link
Contributor Author

@alassek Yes it's been working great for me in 5.2! The only issue was the syntax error caused by this typo. Thanks for merging it to master and looking forward to a release!

@alassek
Copy link
Owner

alassek commented Feb 22, 2019

@pedantic-git v0.2.1 has been pushed up to rubygems, thanks again for the PR

@pedantic-git
Copy link
Contributor Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants