Show usages of a step implementation

[zabil]

Show a code lens over the step implementation that will bring up a usages view.

Acceptance criteria

• List number of usages above the step implementation

2 references
step("Vowels in English language are <vowels>.", function(vowelsGiven) {
  assert.equal(vowelsGiven, vowels.join(""));
});

• If the step has multiple implementations then all the implementations should show the usages

Test cases

• Should list number of usages
• Multiple implementations should show all the usages

[nehashri]

should be available in nightly gauge, gauge-js, gauge-vscode >= 07-11-2017

[sswaroopgupta]

Issues

• Multiple step implementations for the same step does not show the warning

[nehashri]

@sguptatw The issue talks about showing code lens for references of step.
The acceptance criteria

If the step has multiple implementations then the warning message should be shown instead of the usage count

and test case

Multiple implementations for the same step should show the warning

looks like it is mixing up problem diagnostics and references.
If a duplicate step implementation exists in a different file, it is hard for the user to find the duplicate. References also will not be shown if we decide to show a warning instead.
Also a code lens cannot be used to show a warning. It is more like an action that can be invoked by a user. It should not be used to show warnings to a user.

To handle the issue you have pointed out, to show a warning
We should be populating it with problem diagnostics for javascript files.
OR
Show another code lens with which takes you to the duplicate implementation.

In either case, it should not be mixed up with showing usages of a step.

[zabil]

If a duplicate step implementation exists in a different file, it is hard for the user to find the duplicate. References also will not be shown if we decide to show a warning instead.

Agreed, didn't consider this scenario.

[zabil]

New test case

• Highlight the step text (Almost all words have vowels) in the preview pane, to locate it easily

[sswaroopgupta]

@nehashri Thanks for the clarification

Question

In code when there is a duplicate step implementation how should the references are displayed?

Current behavior
If the step implementations are in 2 different files, the number of usages are displayed for all the duplicate step implementations.
If the duplicate step implementation is in the same file, only one of the step implementations have the usage number. The other step implementation(s) will not have the code lens link.

How should this be handled?

[zabil]

In code when there is a duplicate step implementation how should the references are displayed?

The references code lens must be displayed for all duplicated methods.

[nehashri]

changes should be available in gauge, gauge-js, gauge-vscode nightly >= 15-11-2017