Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move runner connections to GRPC #1500

Closed
nehashri opened this issue Oct 11, 2019 · 2 comments
Closed

Move runner connections to GRPC #1500

nehashri opened this issue Oct 11, 2019 · 2 comments
Assignees

Comments

@nehashri
Copy link
Contributor

nehashri commented Oct 11, 2019

Currently, we have gRPC support when Gauge runs in the LSP mode (when start from vscode or gauge daemon --lsp). We should support gRPC for execution and completely remove RPC.

For this to be effective, we need to ensure that Gauge works with both TCP and gRPC for awhile. Some plugins may choose to use gRPC and Gauge should establish a connection with these plugins through gRPC. If the plugin doesn't specify its preference TCP should be used by default.

@nehashri nehashri added this to the Technical Debt milestone Oct 11, 2019
@BugDiver BugDiver mentioned this issue Oct 14, 2019
@BugDiver
Copy link
Member

BugDiver commented Oct 21, 2019

The changes which needs to be done

In Gauge

  • Figure out if runner has full support for gRPC (for execution/lsp)
  • Start the runner and figure out the gRPC server port
  • Create a client and register required service (lsp or runner),
  • Establish a connection with the Server

In runner

  • Add an gRPCSupport property in runner.json
  • Implement runner gRPC services.
  • Start the gRPC runner at a random port.
  • Log the port info on the stdout (gauge captures it to make a connection)
  • Add the service handler and wait till terminated
  • Dotnet
  • Java
  • Java (Multithreading)
  • Javascript
  • Javascript (Multithreading)
  • Python
  • Ruby

BugDiver pushed a commit that referenced this issue Oct 22, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Oct 24, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Oct 24, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Oct 24, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Oct 24, 2019
@negiDharmendra negiDharmendra self-assigned this Oct 24, 2019
BugDiver pushed a commit that referenced this issue Oct 25, 2019
BugDiver pushed a commit that referenced this issue Nov 4, 2019
BugDiver pushed a commit that referenced this issue Nov 4, 2019
BugDiver pushed a commit that referenced this issue Nov 5, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Nov 11, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Nov 11, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Nov 11, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Nov 11, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Nov 11, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Nov 11, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Nov 12, 2019
shubhamsc pushed a commit to getgauge/gauge-ruby that referenced this issue Nov 13, 2019
shubhamsc pushed a commit to getgauge/gauge-ruby that referenced this issue Nov 13, 2019
shubhamsc pushed a commit to getgauge/gauge-ruby that referenced this issue Nov 13, 2019
shubhamsc pushed a commit to getgauge/gauge-ruby that referenced this issue Nov 13, 2019
shubhamsc pushed a commit to getgauge/gauge-ruby that referenced this issue Nov 13, 2019
shubhamsc pushed a commit to getgauge/gauge-ruby that referenced this issue Nov 13, 2019
shubhamsc pushed a commit to getgauge/gauge-ruby that referenced this issue Nov 13, 2019
negiDharmendra added a commit to getgauge/gauge-ruby that referenced this issue Dec 20, 2019
negiDharmendra added a commit to getgauge/gauge-js that referenced this issue Jan 8, 2020
negiDharmendra added a commit to getgauge/gauge-js that referenced this issue Jan 10, 2020
@Debashis9012
Copy link
Contributor

All the above runners have been tested and working as excepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants