read specs args from stdin pipe #2061
Conversation
fixes #1991 Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
| @@ -39,7 +41,8 @@ var ( | |||
| GaugeCmd = &cobra.Command{ | |||
| Use: "gauge <command> [flags] [args]", | |||
| Example: ` gauge run specs/ | |||
| gauge run --parallel specs/`, | |||
| gauge run --parallel specs/ | |||
| cat run.txt | gauge run # run.txt contains list of specs to execute`, | |||
There was a problem hiding this comment.
Will this work?
gauge run < run.txt
That's probably the semantic way of passing run list.
There was a problem hiding this comment.
I am now having second thoughts on this idea. This implementation is getting way too complex for what it serves.
Some things I realized:
- getting pipes to work cross platform is possible, but the semantics are different so there will be a learning curve for users.
- if stdin is not a tty, it does not mean that data is getting piped in! ex - maven/gradle plugins launch gauge as a subprocess, and this will make the stdin non-tty. So the only way to know that stdin is a pipe is to get the file descriptor. Again, this can be tricky across platforms (at least I do not know of a reliable way to do this).
- The IDE plugins also invoke gauge run. If there is ever a requirement to pipe in data, this can get complicated.
I am now considering that we just do the file approach, having support for something like gauge run -f run.json where the run.json is basically a serialized args list.
Thoughts @zabil?
There was a problem hiding this comment.
Yes that's right, for cross compatibility and working with build tools like maven, gradle and npm it makes sense to provide this as file option.
I also feel it's useful to have this per environment and convention in the env folder like args.json
|
Closing this. We should use a file to allow this instead. See conversation above. |
No description provided.