Exit with non-zero code if docs plugin has error #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit running a documentation plugin resulted in a zero exit code even if the plugin explicitly returned an error. This meant that in a CI/CD pipeline, for instance, the pipeline couldn't check the exit code and instead had to check the console or log output, which was brittle. Fixes getgauge#2080 Signed-off-by: John Boyes <154404+johnboyes@users.noreply.github.com>
|
Have bumped the Gauge version from |
sriv
previously approved these changes
Aug 20, 2021
|
@johnboyes Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Signed-off-by: John Boyes <154404+johnboyes@users.noreply.github.com>
sriv
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit running a documentation plugin resulted in a zero
exit code even if the plugin explicitly returned an error. This meant
that in a CI/CD pipeline, for instance, the pipeline couldn't check the
exit code and instead had to check the console or log output, which was
brittle.
Fixes #2080
Signed-off-by: John Boyes 154404+johnboyes@users.noreply.github.com