Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rows in table driven scenario are wrongly linked #64

Closed
mahendrakariya opened this issue Apr 28, 2016 · 5 comments
Closed

Rows in table driven scenario are wrongly linked #64

mahendrakariya opened this issue Apr 28, 2016 · 5 comments
Assignees
Labels

Comments

@mahendrakariya
Copy link
Contributor

mahendrakariya commented Apr 28, 2016

Expected behavior

In a table driven scenario, when a user clicks on a row, reports should show details for that particular row.

Actual behavior

In a table driven scenario, when a user clicks on a row, reports are show details for some other row.

Steps to reproduce

  1. Create a new table driven spec.
  2. Run a few rows of the table excluding the first row. So, something like gauge --table-rows="3-7" specs
@mahendrakariya
Copy link
Contributor Author

Dependent on getgauge/gauge#363

@apoorvam
Copy link
Contributor

The dependent issue getgauge/gauge#363 is fixed and this is implemented in commit.

Fix should be available in nightly >= 26.10.2016

@sswaroopgupta
Copy link

when the entire spec is skipped, all the table rows are still green. Another thing to be taken care of is when I click the skipped row, I should be able to see the details of the spec.

Specification Heading
=====================
tags: top

     |table|d1|d2|3d|d|
     |-----|--|--|--|-|
     |d    |d |  |d |d|
     |d    |d |  |d |d|
     |d    |d |  |d |d|
     |d    |d |  |d |d|

* volume
c
-
tags: scenario3 ppp a b c d e f g h i j k l m n o p q r s t u v w x y z

* Criaçãosdf

c1
--
tags: scenario3 ppp a b c d e f g h i j k l m n o p q r s t u v w x y z

* pass
mhvbmh
___
* pass

@apoorvam
Copy link
Contributor

apoorvam commented Nov 29, 2016

Dev notes:

when the entire spec is skipped, all the table rows are still green.

In order to fix above issue, changes has to be done in Gauge-core.

When a table-driven spec is skipped for steps being unimplemented, the field IsTableDriven in ProtoSpec is not set to true. It retains the default value of bool, false.

Also, the scenario results for all the table rows is not updated. The method SkipSpec() here uses specResult.AddScenarioResults() method, whereas in case of table driven spec it should use specResult.AddTableDrivenScenarioResult() to update all fields.

@apoorvam
Copy link
Contributor

apoorvam commented Dec 6, 2016

when the entire spec is skipped, all the table rows are still green.

This particular case is already tracked in issue #101. So this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants