Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not skip chromium download when env is set to false #256

Closed
sswaroopgupta opened this issue Nov 9, 2018 · 2 comments
Closed

Should not skip chromium download when env is set to false #256

sswaroopgupta opened this issue Nov 9, 2018 · 2 comments

Comments

@sswaroopgupta
Copy link
Contributor

Expected behavior
Should download chromium when TAIKO_SKIP_CHROMIUM_DOWNLOAD is false

Actual behavior
Download is getting skipped
chromium_skip_false

Steps to replicate

This is skipping the chromium download. It should not as TAIKO_SKIP_CHROMIUM_DOWNLOAD is set to false

Blocks #246
@NivedhaSenthil
Copy link
Member

Fix available in e7823ca

@NivedhaSenthil
Copy link
Member

As discussed any value other than false will skip downloading chromium now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sswaroopgupta @NivedhaSenthil