Provide more details in dot api #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugDiver
requested changes
Oct 1, 2019
lib/repl/repl.js
Outdated
| @@ -266,7 +266,24 @@ function displayUsageFor(name) { | |||
| return; | |||
| } | |||
| console.log(); | |||
| if (e.deprecated) { | |||
| console.log(`DEPRECATED ${desc(e.deprecated)}`); | |||
| console.log(); | |||
There was a problem hiding this comment.
Any specific reason for empty console.log?
If it is just to achieve a new line, consider using '\n'. If worried about os specific new lines consider using require('os').EOL.
There was a problem hiding this comment.
I was reusing what was previously in place. EOL is a better fit as suggested.
lib/repl/repl.js
Outdated
| e.returns.map(e => { | ||
| console.log(`Returns: ${type(e.type)} ${(e.description.type ? desc(e.description) : e.description)}`); | ||
| }) | ||
| console.log(); |
|
@BugDiver There seems to be a lot of files not linted properly, running |
|
I guess that would be better. |
BugDiver
approved these changes
Oct 3, 2019
|
@BugDiver @M4rk9696 There is a pre-commit hook that does linting. https://github.com/getgauge/taiko/blob/master/package.json#L30-L33 |
|
@saikrishna321 I think it is better to have a lint stage in CI as well, as a hook can be skipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide more details in dot api