Populate user dir once (#44) #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found another way to install grav by populating user dir if empty during container start. Therefore i skip user dir during build. A script will then populate /var/www/user as described in README.md This commit also includes https://github.com/Freiheitswolke/docker-grav/tree/fix/volume and some changes to README.md to reflect the changed volumes. The commit will not break the old way with a mount for the whole '/var/www/html' for those who want to upgrade grav via the admin console. Building or pulling the container image with the new version of grav is a more proper way to perform upgrades in my opinion. Closes getgrav#44
|
This works great a year later still. For anyone still looking to use this, use these changes along with a source image change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found another way to install grav by populating user dir if empty during container start. Therefore i skip user dir during build. A script will then populate /var/www/user as described in README.md
This commit also includes https://github.com/Freiheitswolke/docker-grav/tree/fix/volume and some changes to README.md to reflect the changed volumes. The commit will not break the old way with a mount for the whole '/var/www/html' for those who want to upgrade grav via the admin console. (If '/var/www/html' is mounted you need to populate the whole directory yourself after starting the container anyway.)
Building or pulling the container image with the new version of grav is a more proper way to perform upgrades in my opinion.
Closes #44
Kind regards and thank you for all the great work so far
Simon