don't disable page ordering when the collection is @self.children and the order is default #1026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the undesirable behaviour of disabling the ordering of a page's children when it defines a collection of items with
header.content.items: @self.children
andheader.content.order.by: default
. In that case, the collection on the front-end is effectively in the order set by the user in the admin panel (which is also the folders prefix order), so it makes sense to enable it and there shouldn't be any confusion like there is when the collection is not the page's children, as explained to me by @rhukster on Slack.Issue #786 was about this. It was closed because a workaround was suggested, but I think this fix is better as it allows you to use some of the great features of collections such as
url_taxonomy_filters
to filter through the page's children to display, in addition to letting the admin set their order.