Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't disable page ordering when the collection is @self.children and the order is default #1026

Closed
wants to merge 1 commit into from

Conversation

benface
Copy link

@benface benface commented Mar 17, 2017

This fixes the undesirable behaviour of disabling the ordering of a page's children when it defines a collection of items with header.content.items: @self.children and header.content.order.by: default. In that case, the collection on the front-end is effectively in the order set by the user in the admin panel (which is also the folders prefix order), so it makes sense to enable it and there shouldn't be any confusion like there is when the collection is not the page's children, as explained to me by @rhukster on Slack.

Issue #786 was about this. It was closed because a workaround was suggested, but I think this fix is better as it allows you to use some of the great features of collections such as url_taxonomy_filters to filter through the page's children to display, in addition to letting the admin set their order.

@rhukster
Copy link
Member

Actually we have a refactoring effort underway to radically change how reordering works for pages. It will focus on numeric prefixes and leave collections completely out of the equation. We also plan to allow you to reorder all siblings in one shot rather than one at a time as you have to now.

@rhukster rhukster closed this Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants