Enable RTL mode for CodeMirror editor #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the missing piece of this commit: codemirror/codemirror5@3c18925#diff-af6b8871a31183cf87b727db7afb5c0a2800f27df16280eaa0f4e8d30fe6b111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: CodeMirror 5 has the capability of being switched to RTL on the fly (cf. https://codemirror.net/5/demo/bidi.html), using the
setOptionmethod on the editor object, e.g.editor.setOption("direction", "rtl").As mentioned here, the Editor instance is exposed in the Grav admin interface. So it should be possible to switch it to RTL as above.
However, this does not work, seemingly because of one missing line of CSS. For although the CodeMirror JS files, as far as I can tell, are pulled in as a dependency and include the RTL-enabling changes made in this commit,
codemirror.cssis hardcoded based on a version from before the commit, and so is missing this addition.The attached commit corrects this accident of history, and provides the option for a plugin or a future feature addition to the Admin plugin to enable the RTL feature of the editor.