Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to name feeds #49

Closed
kevquirk opened this issue Aug 30, 2019 · 0 comments · Fixed by #57
Closed

Add ability to name feeds #49

kevquirk opened this issue Aug 30, 2019 · 0 comments · Fixed by #57

Comments

@kevquirk
Copy link

At the moment there is an option to set a feed's description, but by default the feed's name is just the same as the page name. So when adding a feed to a feed reader, the feed imports as "Home" or "Blog".

It would be nice to have an option to override this with a descriptive name, such as "John Smith's Blog", as it will make it easier for people to identify our feeds when importing them into a feed reader.
@nbusseneau nbusseneau mentioned this issue Sep 1, 2020
Merged
rhukster pushed a commit that referenced this issue Oct 11, 2020
@nbusseneau
Plugin overhaul (#57)
1b80923 
* Rely on LangSwitcher plugin when available

If LangSwitcher is enabled, use current language provided by LangSwitcher as RSS feed language code, superseding lang code from Feed plugin settings.

* Use Grav current language rather than LangSwitcher / lang setting

Grav current language is always available, thus it can relied upon even
when LangSwitcher is not installed, and supersede `lang` setting at all
times.

* Fix default configuration in README

* Add title parameter

Fixes #49.

Like other parameters, can be specified via plugin settings but also
overriden at page level.

* Add show last modified parameter

* Add format specifications

* Fix `atom:updated` calculation (on `<feed>`)

Take into account `modified` if enabled via `show_last_modified`.

* Add `lastBuildDate` to RSS feeds

Take into account `modified` if enabled via `show_last_modified`.

* Use title parameter in feeds

Fixes #49 along with 5d38826.

* Fix feed links

Root URLs suffixed with current URI is more reliable than recomputing
URI via route and extension.

Also fixes #55.

* Fix feed backlinks to feed origin page

* Fix RSS category tags

As strange as it may seem, having multiple `<category>` tags in the same
`<item>` is how it's supposed to be done according to specifications.

* Use file modified in `atom:updated` (on `<entry>`)

Take into account `modified` if enabled via `show_last_modified`.

* Remove default author

Already has a default value at Grav level, redundant.

* Fix Atom `<entry>` category tags

Labels are optional and unnecessary, raw tags should be sufficient and
reflect actual taxonomy better.

* Shuffle around some tags for better coherence

* Fix JSON feed date formats

* Fix JSON feed item content truncation

* Refactor JSON feed and items "default" fields

For better readibility, all default fields are setup in a single JSON
object.

* Fix JSON item `image`

`post_image` does not exist in the specification.

* Add some optional fields to JSON feed items

Of note, JSON feeds are the only ones capable of having both item
content and content summary, hence why we can leverage
`item.header.metadata.description` if present.

* Fix Atom and RSS feeds bad formatting due to whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plugin overhaul
1 participant
@kevquirk