Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change item source from summary to whole content (before truncating) #16

Merged
merged 2 commits into from
Mar 9, 2017
Merged

Change item source from summary to whole content (before truncating) #16

merged 2 commits into from
Mar 9, 2017

Conversation

lape
Copy link
Contributor

@lape lape commented Mar 7, 2017

Solves issue #15: think in order to support untruncated feeds the item source should be the whole unsummarized post before being truncated according to length parameter.

@rhukster rhukster merged commit 2b7f308 into getgrav:develop Mar 9, 2017
@lape lape deleted the lape-patch-1 branch March 10, 2017 16:35
@rsmarples
Copy link

I still got truncation. I solved that by removing truncate_html(collection.params.length) as well.
Is there a setting I missed which influences that?

@flaviocopes
Copy link
Contributor

@rsmarples just make sure you set the length to 0 in the config.

Also, this is still unreleased

@rsmarples
Copy link

@flaviocopes ok, this works setting the yaml manually.
Using the admin panel I get Validation failed: Invalid input in "Feed Length" when trying to set zero.

Unsure what you mean by unreleased, I updated all plugins today and got this change!

@rhukster
Copy link
Member

    length:
      type: text
      label: Feed Length
      validate:
        type: number
        min: 10
        max: 10000

Blueprint has min: 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants